Skip to content

Commit

Permalink
Revert "std::rt: Use a constant 4 threads for multithreaded sched tests"
Browse files Browse the repository at this point in the history
This workaround was less than ideal. A better solution is to raise the
fd limit.

This reverts commit 49b72bd.
  • Loading branch information
lilyball committed Aug 3, 2013
1 parent 3ddc72f commit 70d2be0
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/libstd/rt/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,18 @@ pub fn run_in_mt_newsched_task(f: ~fn()) {
use os;
use from_str::FromStr;
use rt::sched::Shutdown;
use rt::util;

let f = Cell::new(f);

do run_in_bare_thread {
let nthreads = match os::getenv("RUST_RT_TEST_THREADS") {
Some(nstr) => FromStr::from_str(nstr).get(),
None => {
// A reasonable number of threads for testing
// multithreading. NB: It's easy to exhaust OS X's
// low maximum fd limit by setting this too high (#7772)
4
// Using more threads than cores in test code
// to force the OS to preempt them frequently.
// Assuming that this help stress test concurrent types.
util::num_cpus() * 2
}
};

Expand Down

0 comments on commit 70d2be0

Please sign in to comment.