Skip to content

Commit

Permalink
auto merge of #6665 : catamorphism/rust/issue-5741, r=nikomatsakis
Browse files Browse the repository at this point in the history
r? @nikomatsakis The way we deal with unreachable expressions in trans is pretty ad hoc,
but this at least doesn't make it worse, and eliminates the LLVM
assertion failure reported in #5741.
  • Loading branch information
bors committed May 21, 2013
2 parents 799f281 + 8c68c4a commit 15e4438
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/librustc/middle/trans/expr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,10 @@ fn trans_rvalue_stmt_unadjusted(bcx: block, expr: @ast::expr) -> block {
let mut bcx = bcx;
let _icx = bcx.insn_ctxt("trans_rvalue_stmt");

if bcx.unreachable {
return bcx;
}

trace_span!(bcx, expr.span, @shorten(bcx.expr_to_str(expr)));

match expr.node {
Expand Down
14 changes: 14 additions & 0 deletions src/test/run-pass/issue-5741.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

fn main() {
return;
while io::stdin().read_line() != ~"quit" { };
}

0 comments on commit 15e4438

Please sign in to comment.