Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add run-rustfix for result_map_unit_fn lint #4571

Closed
wants to merge 1 commit into from
Closed

Add run-rustfix for result_map_unit_fn lint #4571

wants to merge 1 commit into from

Conversation

phansch
Copy link
Member

@phansch phansch commented Sep 25, 2019

cc #3630

@phansch phansch mentioned this pull request Sep 25, 2019
Closed
39 tasks
@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 25, 2019
Manishearth
Manishearth approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocked on rustup

Manishearth
Manishearth reviewed Sep 25, 2019
View reviewed changes
tests/ui/result_map_unit_fn_non_rustfix.stderr
@@ -0,0 +1,102 @@
error: called `map(f)` on an Result value where `f` is a unit function
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm usually calling these files unfixable, which lets us also call files fixable

(I'm only calling files fixable if there are very few things in that file, otherwise it's just the "main" file)

@Manishearth
Copy link
Member

I ended up fixing this alongside option_map_unit_fn in #4575, and also fixing one of the suggestions.

@phansch
Copy link
Member Author

phansch commented Sep 25, 2019

@Manishearth cool, thanks! I'll close this one then

@phansch phansch closed this Sep 25, 2019
@phansch phansch deleted the result_map_unit_fn_rustfix branch September 25, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phansch @Manishearth