-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Place::Local(x) is now Place::Base(PlaceBase::Local(x)) #3823
Conversation
@oli-obk this is mergeable now, just force pushed again because there was a conflict. |
@spastorino it doesn't build:
|
clippy_lints/src/redundant_clone.rs
Outdated
@@ -229,7 +229,7 @@ fn is_call_with_ref_arg<'tcx>( | |||
if_chain! { | |||
if let TerminatorKind::Call { func, args, destination, .. } = kind; | |||
if args.len() == 1; | |||
if let mir::Operand::Move(mir::Place::Local(local)) = &args[0]; | |||
if let mir::Operand::Move(mir::Place::Base(PlaceBase(Local(local))) = &args[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if let mir::Operand::Move(mir::Place::Base(PlaceBase(Local(local))) = &args[0]; | |
if let mir::Operand::Move(mir::Place::Base(PlaceBase(Local(local)))) = &args[0]; |
It should fix the error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mati865 doh but that's not the issue. PlaceBase::Local
is the thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I admit I haven't checked it deeply, thanks for the explanation.
@bors r+ p=10 |
📌 Commit 77a67c9 has been approved by |
Place::Local(x) is now Place::Base(PlaceBase::Local(x)) We need to merge this after the beta cut for this rust-lang/rust#58631 to work. /cc @oli-obk
☀️ Test successful - checks-travis, status-appveyor |
We need to merge this after the beta cut for this rust-lang/rust#58631 to work.
/cc @oli-obk