This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Enable nightly flag for cargo #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So for the #1043 the RLS built from Rust repo should work now (thanks to stabilized 2018 edition and updated tools' submodules in rust-lang/rust#54057). As specified in cargo/core/features.rs this should be set to true for our internal cargo invocations, which is good! I'd like to make sure that this is set for all our Cargo invocations. In particular, since this modifies a thread-local variable I think it might be worth doing it also when we spawn Cargo as our build process? |
|
It's already set here? |
|
You're right! Sorry, didn't get to last bit yesterday myself. Thanks! bors r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Sep 10, 2018
1045: Enable nightly flag for cargo r=Xanewok a=kngwyu For #1043 But I want to note here that racer has not yet implemented 2018 style path features completely(e.g. see racer-rust/racer#916). So to make all things work we have to do additional works on racer side. Co-authored-by: kngwyu <yuji.kngw.80s.revive@gmail.com>
Build failed |
|
bors r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Sep 11, 2018
1045: Enable nightly flag for cargo r=Xanewok a=kngwyu For #1043 But I want to note here that racer has not yet implemented 2018 style path features completely(e.g. see racer-rust/racer#916). So to make all things work we have to do additional works on racer side. Co-authored-by: kngwyu <yuji.kngw.80s.revive@gmail.com>
Build failed |
kngwyu
force-pushed
the
cargo-nightly
branch
from
b0204dc to
58f69fb
Compare
|
Since bors failure looks related to #1050 I rebased. |
|
bors r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Sep 17, 2018
1045: Enable nightly flag for cargo r=Xanewok a=kngwyu For #1043 But I want to note here that racer has not yet implemented 2018 style path features completely(e.g. see racer-rust/racer#916). So to make all things work we have to do additional works on racer side. Co-authored-by: kngwyu <yuji.kngw.80s.revive@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1043
But I want to note here that racer has not yet implemented 2018 style path features completely(e.g. see racer-rust/racer#916).
So to make all things work we have to do additional works on racer side.