Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

const_eval: update for const_mut_refs and const_refs_to_cell stabilization #1590

Merged
merged 2 commits into from
Sep 15, 2024
Merged

const_eval: update for const_mut_refs and const_refs_to_cell stabilization #1590

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bacab1
const_eval: update for const_mut_refs and const_refs_to_cell stabiliz…
RalfJung Aug 27, 2024
ace105a
talk about const contexts, not const items
RalfJung Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/const_eval.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,11 @@ to be run.
* [Closure expressions] which don't capture variables from the environment.
* Built-in [negation], [arithmetic], [logical], [comparison] or [lazy boolean]
operators used on integer and floating point types, `bool`, and `char`.
* Shared [borrow]s, except if applied to a type with [interior mutability].
* The [dereference operator] except for raw pointers.
* All forms of [borrow]s, including raw borrows, with one limitation:
mutable borrows and shared borrows to values with interior mutability
are only allowed to refer to *transient* places. A place is *transient*
if it will be deallocated before the end of evaluating the current constant item.
Copy link
Contributor

@traviscross traviscross Aug 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that not all const contexts are syntactically items, though they are desugared that way, would it be better here to say "end of evaluating the current constant context"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If "evaluating a const context" is meaningful, then yeah that would work. It sounds a bit odd to me, how can you evaluate a "context"? The context is what the evaluation occurs in.

No strong preference either way.

Copy link
Contributor

@traviscross traviscross Aug 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "evaluating the contents of the current const context"? Open to other ideas.

The main thrust is that const context is something we define and seems to be closer to what we mean here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"evaluating the item" is how we call it in the compiler so I got used to that one. ;)

* The [dereference operator].
* [Grouped] expressions.
* [Cast] expressions, except
* pointer to address casts and
Expand Down