Assume masks are correct #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows miri to detect when they are not, and may be exploited by LLVM during optimization.
programmerjake
approved these changes
Dec 14, 2023
|
maybe wait till the |
calebzulawski
approved these changes
Dec 14, 2023
calebzulawski
added a commit
that referenced
this pull request
Feb 17, 2024
Revert #385 and add some minor fixes
calebzulawski
added a commit
that referenced
this pull request
Feb 17, 2024
…ss-out-of-u-and-me"" This reverts commit 644bdfb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows miri to detect when they are not, and may be exploited by LLVM during optimization. Closes #384.
Are there any other places we want to inject such assumptions? I avoided it on the
test_uncheckedand such because I think it is likely unnecessary on those cases and may result in aggressive over-optimization, but anywhere it's likely to be called once instead of once-per-element seems like a fine place to put anassume.