Skip to content

Commit

Permalink
Auto merge of #117115 - zetafunction:linking, r=bjorn3
Browse files Browse the repository at this point in the history
Mark .rmeta files as /SAFESEH on x86 Windows.

Chrome links .rlibs with /WHOLEARCHIVE or -Wl,--whole-archive to prevent the linker from discarding static initializers. This works well, except on Windows x86, where lld complains:

  error: /safeseh: lib.rmeta is not compatible with SEH

The fix is simply to mark the .rmeta as SAFESEH aware. This is trivially true, since the metadata file does not contain any executable code.
  • Loading branch information
bors committed Oct 26, 2023
2 parents f513928 + cf7751d commit 3e693e5
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 3e693e5

Please sign in to comment.