Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display of sidebar when JS is disabled #2529

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix display of sidebar when JS is disabled #2529

merged 1 commit into from
Jan 20, 2025

Conversation

GuillaumeGomez
Copy link
Member

Fixes #2528.

For the GUI test, I need to update the framework to allow to select an element inside a frame (opened GuillaumeGomez/browser-UI-test#628 for it).

cc @notriddle

@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Jan 20, 2025
ehuss
ehuss approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss added this pull request to the merge queue Jan 20, 2025
Merged via the queue into rust-lang:master with commit 629c2ad Jan 20, 2025
12 checks passed
@GuillaumeGomez GuillaumeGomez deleted the fix-sidebar-display branch January 20, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notriddle notriddle notriddle approved these changes

@ehuss ehuss ehuss approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidebar renders badly when JS is disabled
4 participants
@GuillaumeGomez @ehuss @notriddle @rustbot