Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ALG_SET_DRBG_ENTROPY and ALG_SET_KEY_BY_KEY_SERIAL constants #3334

Closed
wants to merge 1 commit into from

Conversation

rzimmerman
Copy link

ALG_SET_KEY_BY_KEY_SERIAL was added in Linux 6.2:
https://elixir.bootlin.com/linux/v6.2.16/source/include/uapi/linux/if_alg.h#L54

Also adding ALG_SET_DRBG_ENTROPY for completeness.

@rustbot
Copy link
Collaborator

rustbot commented Sep 1, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rzimmerman
Copy link
Author

Regarding the test failures, I think the jammy package for linux-headers is still tied to kernel version 5.15, so this constant is missing.

@bors
Copy link
Contributor

bors commented Oct 28, 2023

☔ The latest upstream changes (presumably #3404) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnTitor
Copy link
Member

We recently updated Ubuntu images to 23.10, please rebase onto main.
Note that our musl header is old and you would have to tweak /~https://github.com/rust-lang/libc/blob/main/libc-test/build.rs.

@tgross35
Copy link
Contributor

@rzimmerman are you able to rebase to finish this?

@tgross35
Copy link
Contributor

@rzimmerman this should just need a rebase if you are able to get it over the line

@tgross35
Copy link
Contributor

Actually this should be all set, #3404 added these constants. Closing since I don't think there is anything remaining here.

@tgross35 tgross35 closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants