Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base rebuild order on last build attempt, not rustc date #2660

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

syphar
Copy link
Member

@syphar syphar commented Nov 2, 2024

There was an issue with rebuilds where a crate that we could build in the past, couldn't be built any more.

Specifically this is an issue with errors in the crate fetch state, because we currently don't store the rustc version for these.

Example: https://docs.rs/crate/flywheel-keybind/0.1.0/builds

For now I just want to change the order and don't try again.

@syphar syphar requested a review from a team as a code owner November 2, 2024 09:11
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Nov 2, 2024
@syphar syphar merged commit fd0fad9 into rust-lang:master Nov 3, 2024
9 checks passed
@syphar syphar deleted the rebuild-order branch November 3, 2024 09:30
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Nov 3, 2024
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants