-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP | Adds ember-service-worker and a couple plugins #835
Conversation
@locks can you describe what the service worked does in this configuration? |
It's caching the API calls? |
@Turbo87 oui |
how? what is the behavior for getting up-to-date data? |
@Turbo87 API calls are like any other ajax call, no? It registers the response for a specific URL in cache. Per the documentation, we are now using a fallback strategy, meaning the cache is only served if no connection is detected. If it's not updating while online, we should look into tweaking the strategy. |
hmm... I think we probably shouldn't do this until we have some sort of indication that you're currently offline and viewing cached data or something like that |
what's the caching strategy for the app assets? |
Maybe we can start by adding service worker for assets and index page? It is pretty safe and will give us a nice boost on second visits. Plus some points in Lighthouse score :) |
@tchak yeah, that's my idea for when I return to contributing here! |
@tchak while I agree that serviceworker support would be good, we should make sure that the error handling in this app is working properly. without serviceworker the page won't load at all if offline, but with serviceworker it will load but won't show any data and timeout at some point. |
I guess we should wait until ember-cli/rfcs#117 has landed before moving forward with this |
Hi ember folks, I'm cleaning up some PRs... I'm betting this is out of date by now, so I'm going to close it! Please reopen if I'm mistaken! Thank you ❤️ |
Currently caches:
/api/v1
calls/summary