Use a common prefix for logged errors #3894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `at=error ` prefix is used for Heroku error messages and using a common prefix aids in metrics collection and is easily searchable.
jtgeibel
force-pushed
the
error-logging-prefix
branch
from
c68b9de to
c608802
Compare
Turbo87
added
A-backend ⚙️
C-internal 🔧
Turbo87
reviewed
Sep 8, 2021
| eprintln!( | ||
| "at=error mod=git error=\"Resetting index from {} to {}\"", | ||
| original_head, head | ||
| ); |
There was a problem hiding this comment.
I'm wondering if we should use error!(...) instead, and use a custom tracing formatter to produce this output. tracing seems to explicitly be made for this kind of structured logging.
|
☔ The latest upstream changes (presumably #4440) made this pull request unmergeable. Please resolve the merge conflicts. |
|
we switched over to using given all that, I guess we can close this PR? let me know if you would like to reopen and still land this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
at=errorprefix is used for Heroku error messages and using a common prefix aids in metrics collection and is easily searchable. This is the first step in monitoring logged errors discussed further in rust-lang/crates-io-heroku-metrics#3.r? @pietroalbini