Fix package::include/exclude tests so they work even if running them not in cargo.git #6260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I ran into this a couple days ago, so I think it's great to get it fixed. For context, this was caused by the warning added in #5858. |
|
ping @dekellum FYI |
|
@bors: r+ |
|
📌 Commit dd998a0 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 5, 2018
Fix package::include/exclude tests so they work even if running them not in cargo.git Otherwise they fail due to mismatching error messages like here https://buildd.debian.org/status/fetch.php?pkg=cargo&arch=all&ver=0.31.0-1%7Eexp1&stamp=1541336261&raw=0 - we don't run `cargo test` from inside `cargo.git` but an unpacked tarball. The test is brittle and only works if the surrounding crate is already inside a git repo but the test-case itself is not. This fixes that by putting the test case inside its own git repo.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise they fail due to mismatching error messages like here https://buildd.debian.org/status/fetch.php?pkg=cargo&arch=all&ver=0.31.0-1%7Eexp1&stamp=1541336261&raw=0 - we don't run
cargo testfrom insidecargo.gitbut an unpacked tarball.The test is brittle and only works if the surrounding crate is already inside a git repo but the test-case itself is not. This fixes that by putting the test case inside its own git repo.