Remove test that requires Emscripten #4973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems relatively unlikely to regress in the future and otherwise arranging Cargo to have a rustc that has Emscripten support will become difficult in the near future in the Rust repo. All in all it seems like the course of action to take is to delete this test for now.
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 5753e1c has been approved by |
bors
added a commit
that referenced
this pull request
Jan 24, 2018
Remove test that requires Emscripten This seems relatively unlikely to regress in the future and otherwise arranging Cargo to have a rustc that has Emscripten support will become difficult in the near future in the Rust repo. All in all it seems like the course of action to take is to delete this test for now.
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Apr 2, 2019
Don't include metadata in wasm binary examples. This removes the metadata hash from wasm example binaries, and consequently also includes the `.wasm` files in the artifact JSON message. Closes #6810. I renamed a method and added a new one to maybe make things a little clearer. This cannot be easily tested (see #4973).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems relatively unlikely to regress in the future and otherwise arranging
Cargo to have a rustc that has Emscripten support will become difficult in the
near future in the Rust repo. All in all it seems like the course of action to
take is to delete this test for now.