Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta 1.69] Backport #11881 Add delays to network retries. #11922

Closed
wants to merge 3 commits into from
Closed

[beta 1.69] Backport #11881 Add delays to network retries. #11922

wants to merge 3 commits into from

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Apr 1, 2023 •
edited
Loading

This is a backport of #11881 to beta. The intent is to help mitigate any potential issues that might crop up with turning sparse index on by default.

This also includes some other changes to get CI passing:

@rustbot
Copy link
Collaborator

rustbot commented Apr 1, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Apr 1, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.69.0. Please double check that you specified the right target!

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation A-git Area: anything dealing with git A-registries Area: registries A-sparse-registry Area: http sparse registries A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2023
@ehuss
Copy link
Contributor Author

ehuss commented Apr 1, 2023 •
edited
Loading

@rust-lang/cargo This is a proposal for a beta backport. I'm not entirely confident backporting this is a good idea, since networking code is generally delicate, and this has risk that it will introduce some regressions. It is also a fairly large amount of code. However, I worry about potential caching issues with the sparse rollout (though there has only been one report of an issue). The change should land in nightly tomorrow, so at least it will git a little bit of testing there.

Let me know whether or not you think we should move forward with this backport.

bors and others added 3 commits April 4, 2023 12:17
@bors @ehuss
[beta 1.69] Backport rust-lang#11881 Add delays to network retries.
72c6b4e
@ehuss
Disable some tests to get CI passing on beta.
efdd8bd 
Due to an update in the output from the latest clap, these tests no
longer pass. I think these aren't likely to have any regressions on beta
or stable, so they are just disabled for now.
@bors @ehuss
Auto merge of rust-lang#11916 - ehuss:test-lto-windows-gnu-disable, r…
32ad843 
…=weihanglo

Disable test_profile test on windows-gnu

This disables the `test_profile` test on windows-gnu due to a regression in nightly, see rust-lang/rust#109797.
@ehuss ehuss force-pushed the beta-http-retry branch from 6125c16 to 32ad843 Compare April 4, 2023 19:18
epage
epage approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with merging this if we agree to the backport

weihanglo
weihanglo approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, thanks!

If we want to backport this, it should be done as early as possible.

@ehuss
Copy link
Contributor Author

ehuss commented Apr 11, 2023

Let's discuss the beta backports at today's meeting.

@ehuss
Copy link
Contributor Author

ehuss commented Apr 11, 2023

Discussed in the meeting, and decided not to backport due to the complexity of the change, and that the default isn't changing until 1.70 (which I was mistaken about).

@ehuss ehuss closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

@epage epage epage approved these changes

Assignees

@epage epage

Labels
A-documenting-cargo-itself Area: Cargo's documentation A-git Area: anything dealing with git A-registries Area: registries A-sparse-registry Area: http sparse registries A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ehuss @rustbot @epage @weihanglo @bors