Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libloading dev dep, run cargo update #650

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Update libloading dev dep, run cargo update #650

merged 1 commit into from
Jan 3, 2025

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Aug 2, 2024

Run

cargo +nightly -Z unstable-options update --breaking
cargo update

@workingjubilee
Copy link
Member

this doesn't mean we have added a third version of addr2line when the submodule is updated in std, does it?

@workingjubilee
Copy link
Member

can this be cut back to just the bindgen change?

@workingjubilee
Copy link
Member

merge conflicts

@atouchet
Copy link
Contributor

addr2line was updated in #638.

@nyurik nyurik requested a review from ChrisDenton August 27, 2024 12:11
@nyurik nyurik changed the title Update all dependencies Update dependencies Aug 28, 2024
@nyurik
Copy link
Contributor Author

nyurik commented Aug 28, 2024

I revised this to only bump miniz_oxide and libloading crates.

@nyurik nyurik changed the title Update dependencies Update libloading dep, run cargo update Aug 28, 2024
@nyurik nyurik changed the title Update libloading dep, run cargo update Update libloading dev dep, run cargo update Aug 28, 2024
@nyurik
Copy link
Contributor Author

nyurik commented Sep 29, 2024

I just rebased this PR - the only change now is the libloading 0.7 -> 0.8, plus some lock updates. It builds fine locally, but CI is having some strange issues, esp with nightly?

@workingjubilee workingjubilee reopened this Jan 3, 2025
@workingjubilee workingjubilee merged commit 154a0ea into rust-lang:master Jan 3, 2025
41 checks passed
@nyurik nyurik deleted the bump-deps branch January 3, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee approved these changes

@ChrisDenton ChrisDenton ChrisDenton approved these changes

Assignees
No one assigned
Labels
S-merge-conflicts S-waiting-on-author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nyurik @workingjubilee @atouchet @ChrisDenton