Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Clone bound from {array,tuple}_combinations #1011

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Remove Clone bound from {array,tuple}_combinations #1011

merged 2 commits into from
Jan 3, 2025

Conversation

ronnodas
Copy link
Contributor

@ronnodas ronnodas commented Jan 3, 2025

Not sure why it was there on tuple_combinations in the first place, and pretty sure it was copied over by mistake on array_combinations.

jswrenn
jswrenn approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@jswrenn jswrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jswrenn jswrenn added this pull request to the merge queue Jan 3, 2025
Merged via the queue into rust-itertools:master with commit 25c1eff Jan 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jswrenn jswrenn jswrenn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronnodas @jswrenn