Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: HeaderRecord::push_tag: Value may be owned #388

Merged
merged 1 commit into from
May 12, 2023
Merged

feat: HeaderRecord::push_tag: Value may be owned #388

merged 1 commit into from
May 12, 2023

Conversation

sjackman
Copy link
Contributor

@sjackman sjackman commented May 5, 2023

The type of the value may be a ref or owned. Previously it must be a ref.

@sjackman
feat: HeaderRecord::push_tag: Value may be owned
2108403 
The type of the value may be a ref or owned. Previously it must be a ref.
@sjackman sjackman changed the title HeaderRecord::push_tag: Value may be owned feat: HeaderRecord::push_tag: Value may be owned May 5, 2023
@coveralls
Copy link

coveralls commented May 5, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4888474809

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 79.045%
Files with Coverage Reduction New Missed Lines %
src/bam/record.rs 1 76.46%
src/utils.rs 1 66.67%
Totals Coverage Status
Change from base Build 4698271908: 0.05%
Covered Lines: 2267
Relevant Lines: 2868
💛 - Coveralls

@johanneskoester johanneskoester merged commit b64537d into rust-bio:master May 12, 2023
@github-actions github-actions bot mentioned this pull request May 12, 2023
Merged
@sjackman sjackman deleted the sj/push_tag branch May 15, 2023 17:11
@sjackman
Copy link
Contributor Author

Thanks for merging, Johannes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanneskoester johanneskoester johanneskoester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjackman @coveralls @johanneskoester