-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Fix tests to match nerdctl 1.2.1 outputs (#50)
Issue #, if available: *Description of changes:* After upgrading `nerdctl` dependency to 1.2.1, [7 e2e tests in finch fail](/~https://github.com/runfinch/finch/actions/runs/4421068149/jobs/7751480288#step:6:12894) due to failed assertions on output strings of finch commands. #### nerdctl images --quiet Output before 1.2.1 ``` $ nerdctl images --quiet 69665d02cb32 ``` Output in 1.2.1 ``` $ nerdctl images --quiet sha256:ff6bdca1701f3a8a67e328815ff2346b0e4067d32ec36b7992c1fdc001dc8517 ``` #### nerdctl run/exec -u/--user Output before 1.2.1 ``` $ nerdctl run -u nobody:100 alpine id uid=65534(nobody) gid=100(users) ``` Output in 1.2.1 ``` $ nerdctl run -u nobody:100 alpine id uid=65534(nobody) gid=100(users) groups=100(users) ``` #### nerdctl run --group-add Output before 1.2.1 ``` $ nerdctl run -u nobody --group-add 100 alpine id uid=65534(nobody) gid=65534(nobody) groups=100(users) ``` Output in 1.2.1 ``` $ nerdctl run -u nobody --group-add 100 alpine id uid=65534(nobody) gid=65534(nobody) groups=100(users),65534(nobody) ``` *Testing done:* Yes, locally. - [X] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Vishwas Siravara <siravara@amazon.com>
- Loading branch information
Showing
3 changed files
with
33 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters