-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure multi-image builds succeed #5257
Merged
Merged
+2
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Urson <dan.urson@cresta.ai>
Signed-off-by: Dan Urson <dan.urson@cresta.ai>
we don't need it any more since we're using true multi-arch builds now. Signed-off-by: Dan Urson <dan.urson@cresta.ai>
only sign top-level manifest Signed-off-by: Dan Urson <dan.urson@cresta.ai>
when testing, push is false and load is true Signed-off-by: Dan Urson <dan.urson@cresta.ai>
notdurson
requested review from
chenrui333,
lukemassa and
X-Guardian
and removed request for
a team
January 20, 2025 20:13
dosubot
bot
added
bug
Something isn't working
docker
Pull requests that update Docker code
github-actions
labels
Jan 20, 2025
github-actions
bot
removed
bug
Something isn't working
docker
Pull requests that update Docker code
labels
Jan 20, 2025
notdurson
changed the title
bug: fix multi-image builds
fix: ensure multi-image builds succeed
Jan 20, 2025
Confirmed that container image signatures are now valid in my fork:
|
Same for the alpine image:
|
X-Guardian
approved these changes
Jan 20, 2025
jamengual
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
we implemented image signing in #5185. unfortunately a logic flaw was introduced in this change which broke multi-architecture builds. the change modified the build steps to use a matrix build. however, the matrix was incorrectly configured, which caused the last arch in the build sequence (linux/arm/v7) to overwrite the other 2 tags. effectively, we steamrolled ourselves.
this change corrects the error by simplifying the matrix. instead of using six parallel build steps, we use a single build step which pushes a multi-arch manifest in one shot. this has the added benefit of speeding builds up.
why
atlantis guarantees the availability of images for multiple CPU architectures. this promise must be kept.
tests
tested by building images in my fork.
references
closes #5222