Fix >= 0.12.0 version detection for versions with prereleases #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1286 +/- ##
=======================================
Coverage 70.05% 70.05%
=======================================
Files 71 71
Lines 5390 5390
=======================================
Hits 3776 3776
Misses 1264 1264
Partials 350 350
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1276
As outlined in hashicorp/go-version#59 go-version Constraints explicitly disallow matches with prerelease versions specified. Most of our other usage of Constraint tend to be for detection of older versions of terraform so there is probably no sense in a global update of these comparisons. In the future it is a good idea for us to opt for the explicit version comparison functions provided by the library.