server: add option to set policy package PVC name via values #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchristidis
reviewed
Feb 26, 2025
| @@ -166,6 +166,10 @@ policyPackages: | |||
| # - moduleName: vo_2_policy_package | |||
| # requirement: git+/~https://github.com/vo-2/vo-2-policy-package@v0.1.0 | |||
| # version: 0.1.0 | |||
| # Set true to create a PVC for the policy packages; leave false if providing it separately. | |||
| createPvc: false | |||
| # If providing the PVC separately, set its name here. | |||
There was a problem hiding this comment.
I am confused by this comment. ‘If separate, then do this.’ But when not ‘if separate’, don’t you need to set it to something that will be unique to the release?
There was a problem hiding this comment.
I see how the comment could be misleading. If not separate (i.e. createPvc: true), you'd still set this name to something unique to the release - the comment was mostly to indicate what to do in case you wanted to provide the PVC separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #238