-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub actions #280
GitHub actions #280
Conversation
445d354
to
7dfa9fc
Compare
I think the CI hits this problem uraimo/run-on-arch-action#4 |
@micheelengronne thanks for the link I appreciate your help! Maybe we can pair in this issue? are you in the bundler channel? if not I can invite you and we can coordinate if you do like that :) |
@bronzdoc I am not in the bundler channel but I would be interested. Thank you. |
@micheelengronne I invited you to the workspace with the email of your Github let me know if that is ok or you need me to add you with another email |
368841b
to
56d17c6
Compare
@micheelengronne Thanks for the sharp eyes 👀 ! I did a revert |
We'll see with @bronzdoc, he is the one full head in that :) |
@bronzdoc 👋 Hi! Hope you're alright and that things are good where you are. Can we move forward with this? |
Sorry for taking that long guys! @olleolleolle can you give me a heads up of what happened here? did you add master but without the two PR that were causing issues is that it? |
I Will get back to this tomorrow |
Hi! I made a too-quick decision on not enough information, and later learned that one of the goals of this PR was to change history of the default branch, to avoid some commits that had become... wrong. That's my current understanding. I won't make any more changes unless you ask me to. (I'm writing this on GitHub's Android app, which misattributed comments, at first, which made it look like @bronzdoc had answered with verbatim responses. Apps, gah. Sorry if I emoji'd on the wrong comment, just now! Edit: this is terrible, I had come to add the laugh emoji to your promise of working on it later today. I will remove that offensive emoji now. I'm rattled. I will not be using this app anymore. Go you!) |
Ohhh nooo! the evil laugh emoji! 😄 No worries @olleolleolle, It's not offensive at all, like at all 😂 My plan was to switch to Github action and fix the spec failures related to the bundler version we use in CI in this PR, then fix the issues introduced by #274 and #270. I removed the commits of #274 and #270 here so I could isolate the bundler problems and work around them(which we did) then I was planning to get those commits back and fix those in separate PR's but also open to revert those commits(in a separate PR) and merge them back to master when we fix the issues in each of them. Let me know what you and @micheelengronne think about this. As always really grateful for your support :) |
@bronzdoc I think that this is a great way to go, and a good way forward. |
46728f9
to
12cec56
Compare
Specs are expected to fail here since we still have the features we are reverting in #293 after that is merged we could expect a green build again |
Merged #293 and rebased master, build is green now 🎉 so I will move forward with this PR |
🎊 |
Description:
~> 1.11
I will abide by the code of conduct.