fix weird t.string "{:null=>false}" bug
#2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to have fixed itself when running migrations locally. Hopefully it doesn't go back to the other way.
compwron
approved these changes
Nov 11, 2021
|
Hey @aedwardg we just spotted it in our project, just in case you're curious: it's ruby-2/ruby-3 related (works fine in 2, creates this "weird" thing in ruby-3). I bet you switched to ruby-3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to have fixed itself when running migrations locally.
Hopefully it doesn't go back to the other way.
What github issue is this PR for, if any?
No official issue, but here's the issue that was opened up on paper trail for the weirdness:
paper-trail-gem/paper_trail#1347