Merge pull request #735 from tompng/fix_invalid_number

Reject invalid number: `-` `-.1` `-e0`
ruby · Jan 20, 2025 · 8f1bba3 · 8f1bba3
2 parents 96079a1 + b9bfeec
commit 8f1bba3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/ext/json/ext/parser/parser.c b/ext/json/ext/parser/parser.c
@@ -990,6 +990,8 @@ static VALUE json_parse_any(JSON_ParserState *state, JSON_ParserConfig *config)
                 raise_parse_error("invalid number: %s", start);
             } else if (RB_UNLIKELY(integer_length > 2 && start[0] == '-' && start[1] == '0')) {
                 raise_parse_error("invalid number: %s", start);
+            } else if (RB_UNLIKELY(integer_length == 1 && start[0] == '-')) {
+                raise_parse_error("invalid number: %s", start);
             }
 
             if ((state->cursor < state->end) && (*state->cursor == '.')) {

diff --git a/test/json/json_parser_test.rb b/test/json/json_parser_test.rb
@@ -109,6 +109,9 @@ def test_parse_numbers
     assert_raise(JSON::ParserError) { parse('-023.12') }
     assert_raise(JSON::ParserError) { parse('023e12') }
     assert_raise(JSON::ParserError) { parse('-023e12') }
+    assert_raise(JSON::ParserError) { parse('-') }
+    assert_raise(JSON::ParserError) { parse('-.1') }
+    assert_raise(JSON::ParserError) { parse('-e0') }
     assert_equal(23, parse('23'))
     assert_equal(-23, parse('-23'))
     assert_equal_float(3.141, parse('3.141'))