Fix pager preview with escape sequence and newlines #1069
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this bug
Non-string
PP doesn't seem to write non-string object, but fix it in case.
Escape sequence
Need to set the second parameter
allow_escape_code
toReline::Unicode.calculate_width
Newline
Reline::Unicode.split_by_width(line.chomp, @width)
wrapped_lines
does not include"\n"
because line is chomp-ed. (split_by_width
does not work if string contains newline character)So we need to add
"\n"
ifline
ends with"\n"
. And the logic had a bug.PP doesn't seem to write continuous newlines, but found while adding more tests.