Revise #582 by changing the way how OPTIONS routes are added #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This is pretty thick :) I'm merging it, but someone should come up with a better way for this whole mess! |
dblock
added a commit
that referenced
this pull request
Mar 27, 2014
Revise #582 by changing the way how OPTIONS routes are added
|
👍 my test suite is now green on HEAD. Thanks for your work @stevschmid. |
|
Glad to hear :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue described in #598. The culprit was the PR #582 which addressed #572 (OPTIONS was broken for paths with versioning). My solution to the problem back then was to work with the "raw" path information of all endpoints instead of using the final routes, because latter contain the
/:versioninformation already. The solution was too simple to address complex nesting and namespacing.This PR reverts the way the OPTIONS paths are collected and addresses the
/:versionissue (of #572) by disabling the addition of path url versioning when the OPTIONS routes are added. I'm not sold on this solution however (feels like a hack), but it might help someone to find a more elegant solution.