Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop and its todo #2450

Merged
merged 3 commits into from
Jun 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,21 +57,18 @@ Metrics/ModuleLength:
Metrics/PerceivedComplexity:
Max: 15

RSpec/Capybara/FeatureMethods:
Enabled: false

RSpec/ExampleLength:
Max: 60

RSpec/NestedGroups:
Max: 6

RSpec/FilePath:
SpecSuffixOnly: true

RSpec/SpecFilePathFormat:
Enabled: false

RSpec/SpecFilePathSuffix:
Enabled: true

RSpec/MultipleExpectations:
Enabled: false

Expand All @@ -83,6 +80,3 @@ RSpec/MultipleMemoizedHelpers:

RSpec/ContextWording:
Enabled: false

RSpecRails/HaveHttpStatus:
Enabled: false
19 changes: 18 additions & 1 deletion .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2024-05-20 14:55:33 UTC using RuboCop version 1.63.2.
# on 2024-06-15 15:12:21 UTC using RuboCop version 1.64.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -197,6 +197,7 @@ RSpec/RepeatedExampleGroupDescription:

# Offense count: 2
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AutoCorrect.
RSpec/ScatteredSetup:
Exclude:
- 'spec/grape/util/inheritable_setting_spec.rb'
Expand Down Expand Up @@ -296,6 +297,22 @@ Style/Semicolon:
Exclude:
- 'spec/grape/api_spec.rb'

# Offense count: 2
# This cop supports safe autocorrection (--autocorrect).
Style/SuperArguments:
Exclude:
- 'lib/grape/api.rb'
- 'spec/support/deprecated_warning_handlers.rb'

# Offense count: 2
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments.
# AllowedMethods: define_method
Style/SymbolProc:
Exclude:
- 'benchmark/large_model.rb'
- 'spec/grape/validations/params_scope_spec.rb'

# Offense count: 1
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: EnforcedStyle.
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

#### Features

* [#2450](/~https://github.com/ruby-grape/grape/pull/2450): Update RuboCop to 1.64.1 - [@ericproulx](/~https://github.com/ericproulx).
* Your contribution here.
ericproulx marked this conversation as resolved.
Show resolved Hide resolved

#### Fixes
Expand Down
4 changes: 2 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ group :development, :test do
gem 'builder', require: false
gem 'bundler'
gem 'rake'
gem 'rubocop', '1.63.2', require: false
gem 'rubocop', '1.64.1', require: false
gem 'rubocop-performance', '1.21.0', require: false
gem 'rubocop-rspec', '2.29.1', require: false
gem 'rubocop-rspec', '3.0.1', require: false
end

group :development do
Expand Down