Skip to content

Commit

Permalink
Merge pull request #353 from koic/change_drop_ruby_2_6_support
Browse files Browse the repository at this point in the history
Drop Ruby 2.6 support
  • Loading branch information
koic authored Apr 18, 2023
2 parents 64c1f14 + 0106053 commit c288aed
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 15 deletions.
6 changes: 0 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ workflows:
build:
jobs:
- documentation-checks
- rake_default:
name: Ruby 2.6
image: cimg/ruby:2.6
- rake_default:
name: Ruby 2.7
image: cimg/ruby:2.7
Expand All @@ -53,6 +50,3 @@ workflows:
- rake_default:
name: Ruby HEAD
image: rubocophq/circleci-ruby-snapshot:latest # Nightly snapshot build
- rake_default:
name: JRuby 9.3
image: circleci/jruby:9.3
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ AllCops:
- 'vendor/**/*'
- 'spec/fixtures/**/*'
- 'tmp/**/*'
TargetRubyVersion: 2.6
TargetRubyVersion: 2.7
SuggestExtensions: false

InternalAffairs/NodeMatcherDirective:
Expand Down
1 change: 1 addition & 0 deletions changelog/change_drop_ruby_2_6_support.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* [#353](/~https://github.com/rubocop/rubocop-performance/pull/353): **(Breaking)** Drop Ruby 2.6 support. ([@koic][])
2 changes: 1 addition & 1 deletion rubocop-performance.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Gem::Specification.new do |s|
s.name = 'rubocop-performance'
s.version = RuboCop::Performance::Version::STRING
s.platform = Gem::Platform::RUBY
s.required_ruby_version = '>= 2.6.0'
s.required_ruby_version = '>= 2.7.0'
s.authors = ['Bozhidar Batsov', 'Jonas Arvidsson', 'Yuji Nakayama']
s.description = <<~DESCRIPTION
A collection of RuboCop cops to check for performance optimizations
Expand Down
4 changes: 2 additions & 2 deletions spec/project_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,9 @@

describe 'link to related issue' do
let(:issues) do
entries.map do |entry|
entries.filter_map do |entry|
entry.match(/\[(?<number>[#\d]+)\]\((?<url>[^)]+)\)/)
end.compact
end
end

it 'has an issue number prefixed with #' do
Expand Down
5 changes: 0 additions & 5 deletions tasks/changelog.rb
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
# frozen_string_literal: true

if RUBY_VERSION < '2.6'
puts 'Changelog utilities available only for Ruby 2.6+'
exit(1)
end

# Changelog utility
class Changelog
ENTRIES_PATH = 'changelog/'
Expand Down

0 comments on commit c288aed

Please sign in to comment.