Add new Minitest/NonPublicTestMethod cop
#229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatkodima
force-pushed
the
hidden_test_method-cop
branch
from
d6f1072 to
3c58541
Compare
|
First, it should be enough if it is confirmed with rails/rails repo 👍 Can you update this cop name to |
koic
reviewed
Jan 18, 2023
config/default.yml
Outdated
| @@ -158,6 +158,11 @@ Minitest/GlobalExpectations: | |||
| VersionAdded: '0.7' | |||
| VersionChanged: '0.26' | |||
|
|
|||
| Minitest/HiddenTestMethod: | |||
| Description: 'Detects hidden (marked as `private` or `protected`) test methods.' | |||
There was a problem hiding this comment.
Suggested change
| Description: 'Detects hidden (marked as `private` or `protected`) test methods.' | |
| Description: 'Detects non public (marked as `private` or `protected`) test methods.' |
koic
reviewed
Jan 18, 2023
config/default.yml
Outdated
| @@ -158,6 +158,11 @@ Minitest/GlobalExpectations: | |||
| VersionAdded: '0.7' | |||
| VersionChanged: '0.26' | |||
|
|
|||
| Minitest/HiddenTestMethod: | |||
| Description: 'Detects hidden (marked as `private` or `protected`) test methods.' | |||
| Enabled: pending | |||
There was a problem hiding this comment.
I think it's probably Severity: warning.
Suggested change
| Enabled: pending | |
| Enabled: pending | |
| Severity: warning |
koic
reviewed
Jan 18, 2023
| module RuboCop | ||
| module Cop | ||
| module Minitest | ||
| # Detects hidden (marked as `private` or `protected`) test methods. Minitest runs only |
There was a problem hiding this comment.
Suggested change
| # Detects hidden (marked as `private` or `protected`) test methods. Minitest runs only | |
| # Detects non `public` (marked as `private` or `protected`) test methods. Minitest runs only |
koic
reviewed
Jan 18, 2023
| include MinitestExplorationHelpers | ||
| include DefNode | ||
|
|
||
| MSG = 'Hidden test method detected. Make it public for it to run.' |
There was a problem hiding this comment.
Suggested change
| MSG = 'Hidden test method detected. Make it public for it to run.' | |
| MSG = 'Non `public` test method detected. Make it `public` for it to run.' |
fatkodima
force-pushed
the
hidden_test_method-cop
branch
from
3c58541 to
80fd3da
Compare
|
Updated. |
fatkodima
changed the title
Minitest/HiddenTestMethod copMinitest/NonPublicTestMethod cop
|
I ran this on Shopify's main app. No errors, and it caught a good number of unintentionally private tests. |
|
Cool! Glad it works. Thank you for checking ❤️ |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #220.
Tested on
rails/rails- no offenses there.Does anyone know other large OSS projects with minitest tests in it?