Replace crayon by cli + address some TODOs to add some color #4170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Are there any performance changes in what's currently in the PR? |
|
Sorry, I should have been clearer. I didn't include the change in question in this PR. I was just storing this unrelated info here to make sure I'd find it when I needed it. |
|
That makes sense; it's also how I interpreted your notes. In other words, since you had looked at the speed, it'd be helpful to know if there are any performance changes in the PR as it is now. Also, if you're still working on this and aren't ready for a review, would you mind changing the PR to a draft to avoid confusion? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed RdMacros since no longer used. (also no longer recommended by pkgdown..
The end goal is to have clickable links in output.
info (to ignore for now)
With a change I have locally (not included here), I am able to acheive the following for the stack trace. However, there is a slowdown. So, I will look into it.