-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the Taylor & Francis journal template #204
Conversation
My printer don't want me to print anything, so I will hand in the contributor agreement later:-) |
Contributor agreement is on its way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you
- leave out the generated files like
skeleton_files/figure-latex/nice-plot-1.pdf
, - minimize the
.bib
file by eliminating the entries that are not actually used in the example (for the demo purpose, one or two entries should suffice), - and get rid of the two eps figure files if possible (you may generate two dynamically from an R code chunk)?
The skeleton.Rmd
looks heavy with LaTeX (so heavy that I'd doubt if it is really worth using R Markdown at all), but I guess there isn't much you could do about it.
Thank you!
Merge branch 'master' of /~https://github.com/dleutnant/rticles # Conflicts: # inst/rmarkdown/templates/tf_article/resources/template.tex
Thank you @yihui! I made the required changes. |
Do you know how to resolve conflicts in git? Your master branch has conflicts with the master branch here. BTW, it is strongly recommended that you use a different branch for each PR, and don't use the master branch. |
OK, I'll open a new PR. |
new PR is now #218. |
To contribute a new article template to this package, please make sure you have done the following things (note that
journalname_article
below is only an example name):Unless you have done it in any other RStudio's projects before, please sign the individual or corporate contributor agreement for a significant pull request (it is fine not to sign it if a PR is only intended to fix a few typos). You can send the signed copy to jj@rstudio.com.
Add the
journalname_article()
function toR/journalname_article.R
. If the article needs CSL to process citations, see the functionacm_article()
for an example; otherwise seeasa_article()
for an example. If you don't know what CSL means, see the latter.Add the Pandoc LaTeX template
inst/rmarkdown/templates/journalname_article/resources/template.tex
.Add a skeleton article
inst/rmarkdown/templates/journalname_article/skeleton/skeleton.Rmd
.Add a description of the template
inst/rmarkdown/templates/journalname_article/template.yaml
.Please include the document class file (
*.cls
) if needed, but please do not include standard LaTeX packages (*.sty
) that can be downloaded from CTAN.Update Rd and namespace (could be done by
devtools::document()
).Update NEWS.
Update README with a link to the newly supported journal.
Add a test to
tests/testit/test-formats.R
.Add your name to the list of authors
Authors@R
in DESCRIPTION. You don't need to bump the package version in DESCRIPTION.Thank you!