Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the Taylor & Francis journal template #204

Closed
wants to merge 15 commits into from
Closed

Adding the Taylor & Francis journal template #204

wants to merge 15 commits into from

Conversation

dleutnant
Copy link
Contributor

@dleutnant dleutnant commented Jan 5, 2019

To contribute a new article template to this package, please make sure you have done the following things (note that journalname_article below is only an example name):

  • Unless you have done it in any other RStudio's projects before, please sign the individual or corporate contributor agreement for a significant pull request (it is fine not to sign it if a PR is only intended to fix a few typos). You can send the signed copy to jj@rstudio.com.

  • Add the journalname_article() function to R/journalname_article.R. If the article needs CSL to process citations, see the function acm_article() for an example; otherwise see asa_article() for an example. If you don't know what CSL means, see the latter.

  • Add the Pandoc LaTeX template inst/rmarkdown/templates/journalname_article/resources/template.tex.

  • Add a skeleton article inst/rmarkdown/templates/journalname_article/skeleton/skeleton.Rmd.

  • Add a description of the template inst/rmarkdown/templates/journalname_article/template.yaml.

  • Please include the document class file (*.cls) if needed, but please do not include standard LaTeX packages (*.sty) that can be downloaded from CTAN.

  • Update Rd and namespace (could be done by devtools::document()).

  • Update NEWS.

  • Update README with a link to the newly supported journal.

  • Add a test to tests/testit/test-formats.R.

  • Add your name to the list of authors Authors@R in DESCRIPTION. You don't need to bump the package version in DESCRIPTION.

Thank you!

@dleutnant
Copy link
Contributor Author

dleutnant commented Jan 5, 2019

My printer don't want me to print anything, so I will hand in the contributor agreement later:-)

@dleutnant
Copy link
Contributor Author

Contributor agreement is on its way.

Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you

  • leave out the generated files like skeleton_files/figure-latex/nice-plot-1.pdf,
  • minimize the .bib file by eliminating the entries that are not actually used in the example (for the demo purpose, one or two entries should suffice),
  • and get rid of the two eps figure files if possible (you may generate two dynamically from an R code chunk)?

The skeleton.Rmd looks heavy with LaTeX (so heavy that I'd doubt if it is really worth using R Markdown at all), but I guess there isn't much you could do about it.

Thank you!

@dleutnant
Copy link
Contributor Author

Thank you @yihui! I made the required changes.
The skeleton.Rmd is indeed quite heavy, but I tried to be as close to the original LaTeX template as possible. Do you want me to substitute the body with sth. like the default rmarkdown::pdf_document template?

@yihui
Copy link
Member

yihui commented Apr 8, 2019

Do you know how to resolve conflicts in git? Your master branch has conflicts with the master branch here. BTW, it is strongly recommended that you use a different branch for each PR, and don't use the master branch.

@dleutnant
Copy link
Contributor Author

OK, I'll open a new PR.

@dleutnant
Copy link
Contributor Author

new PR is now #218.

@dleutnant dleutnant closed this Apr 8, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants