Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update counter example #2305

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Update counter example #2305

merged 2 commits into from
Mar 13, 2023

Conversation

K9i-0
Copy link
Contributor

@K9i-0 K9i-0 commented Mar 12, 2023

enable riverpod_lint

There was riverpod_lint in dev_dependencies, but since custom_lint was not added in analysis_options, I modified analysis_options.yaml.

remove unnecessary Consumer

After checking the History, there was a Consumer added when the example was using StatelessWidget, but it seemed unnecessary now since it has been replaced with ConsumerWidget, so I removed it.
c44d952

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Merging #2305 (b4fea06) into master (6031730) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2305   +/-   ##
=======================================
  Coverage   95.24%   95.24%           
=======================================
  Files          53       53           
  Lines        2250     2250           
=======================================
  Hits         2143     2143           
  Misses        107      107           

@robpot95
Copy link

Correct me if i'm wrong. But consumer is there to narrow rebuild to only the Text widget

@K9i-0
Copy link
Contributor Author

K9i-0 commented Mar 13, 2023

I think the feedback is correct. However, since the example Widget is very simple, I felt that it would be better to improve readability by removing the Consumer rather than reducing the rebuild scope.

@rrousselGit rrousselGit merged commit 88f9903 into rrousselGit:master Mar 13, 2023
@rrousselGit
Copy link
Owner

Thanks!

@K9i-0 K9i-0 deleted the update_counter_example branch March 14, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants