Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #857, q whitespace comment #858

Merged
merged 3 commits into from
Aug 19, 2019
Merged

fix #857, q whitespace comment #858

merged 3 commits into from
Aug 19, 2019

Conversation

mkst
Copy link
Contributor

@mkst mkst commented Jan 6, 2018

A fix for Issue #857

@gfx
Copy link
Member

gfx commented Jan 31, 2018

@mkst
Copy link
Contributor Author

mkst commented Feb 1, 2018

@gfx I've added a simple example of a comment with leading whitespace to the samples/q file.

@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Aug 16, 2019
Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @streetster. I joined the team of maintainers a couple of months back and have been working my way through the backlog of outstanding PRs in reverse chronological order. I'm sorry it's been such a long wait :(

I've got to your submission for the Q lexer and had a question about how Q's comment syntax works.

lib/rouge/lexers/q.rb Show resolved Hide resolved
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed needs-review The PR needs to be reviewed and removed needs-review The PR needs to be reviewed author-action The PR has been reviewed but action by the author is needed labels Aug 16, 2019
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Aug 19, 2019
@pyrmont pyrmont merged commit 05d217d into rouge-ruby:master Aug 19, 2019
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Aug 19, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Aug 19, 2019

Thanks @streetster! Sorry it took so long but hey, it's finally done :)

We're releasing new versions of Rouge every two weeks as we clear the backlog of outstanding PRs. The next release is due this coming Tuesday so the fix will roll out very soon. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants