Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist nav2 pkgs on Rolling and Iron #285

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Conversation

Yadunund
Copy link
Member

@Yadunund Yadunund commented Sep 26, 2023

Signed-off-by: Yadunund <yadunund@openrobotics.org>
@Yadunund Yadunund requested a review from cottsay as a code owner September 26, 2023 05:19
@@ -17,6 +17,7 @@ package_blacklist:
- kortex_bringup # depends on kortex_api and kortex_driver
- kortex_driver # depends on kortex_api and uses libKortexApiCpp.a from Kinova
- mapviz # Known issues with building on ARM processors. /~https://github.com/swri-robotics/mapviz/issues/777
- nav2_bringup # depends on turtlebot3_gazebo which is unavailable

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is categorically missing forever and ever to be backlisted. There's work on the gazebo side, but its not unworkable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. In that case I will whitelist it on Rolling but leave it blacklisted on Iron for now.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Especially also considering we will eventually migrate completely away from the TB3 and Gazebo classic by EOY. This is an odd transitory state

Signed-off-by: Yadunund <yadunund@openrobotics.org>
@cottsay
Copy link
Member

cottsay commented Sep 26, 2023

The reason the nav2 packages are failing on RHEL is due to the dependency on xtensor (introduced in ros-navigation/navigation2#3350, rosdep rules do not list RHEL, package is currently not available).

Can you update the "reason" in the comment to reflect the missing package as the root cause?

Signed-off-by: Yadunund <yadunund@openrobotics.org>
@Yadunund
Copy link
Member Author

The reason the nav2 packages are failing on RHEL is due to the dependency on xtensor (introduced in ros-planning/navigation2#3350, rosdep rules do not list RHEL, package is currently not available).

Can you update the "reason" in the comment to reflect the missing package as the root cause?

ooh I see. Thanks for hunting down the cause. Let me know if the new comment is better.

@cottsay
Copy link
Member

cottsay commented Sep 26, 2023

Thanks, looks good. There is also a linter warning: /~https://github.com/ros2/ros_buildfarm_config/pull/285/files#diff-9f0c82d1eeac7ed26941b0d693125cb96ccdc63d7f5e220a4445fd7ccc3be1e9

Signed-off-by: Yadunund <yadunund@openrobotics.org>
@SteveMacenski
Copy link

Can you update the "reason" in the comment to reflect the missing package as the root cause?

I believe there are a few reasons. There's also no OMPL which kills the Smac Planner. I believe there's a couple of others

@cottsay
Copy link
Member

cottsay commented Sep 26, 2023

I believe there are a few reasons. There's also no OMPL which kills the Smac Planner. I believe there's a couple of others

Having ompl blocked here will automatically block downstream packages, so that's not a reason to block these packages here and now.

xtensor is the only missing rosdep rule to unblock Bloom in the navigation2 repository. Once that's resolved, we can remove all of them from this list, at which point nav2_smac_planner would still be disabled implicitly due to the ompl dependency.

I'm working on getting xtensor into EPEL 9.

Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's typically only necessary to block the most upstream packages in this list, as downstream packages would be disabled implicitly, but navigation2 has a lot of packages and it might be hard to tease apart.

I'm also hoping to get these unblocked in the not-too-distant future, so hopefully this will be short-lived.

@Yadunund
Copy link
Member Author

Wow that's great to hear, Scott!

@Yadunund Yadunund merged commit 027f596 into ros2 Sep 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the yadu/blacklist_nav2_rhel branch September 27, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants