-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blacklist nav2 pkgs on Rolling and Iron #285
Conversation
Signed-off-by: Yadunund <yadunund@openrobotics.org>
@@ -17,6 +17,7 @@ package_blacklist: | |||
- kortex_bringup # depends on kortex_api and kortex_driver | |||
- kortex_driver # depends on kortex_api and uses libKortexApiCpp.a from Kinova | |||
- mapviz # Known issues with building on ARM processors. /~https://github.com/swri-robotics/mapviz/issues/777 | |||
- nav2_bringup # depends on turtlebot3_gazebo which is unavailable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is categorically missing forever and ever to be backlisted. There's work on the gazebo side, but its not unworkable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. In that case I will whitelist it on Rolling but leave it blacklisted on Iron for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Especially also considering we will eventually migrate completely away from the TB3 and Gazebo classic by EOY. This is an odd transitory state
Signed-off-by: Yadunund <yadunund@openrobotics.org>
The reason the nav2 packages are failing on RHEL is due to the dependency on Can you update the "reason" in the comment to reflect the missing package as the root cause? |
Signed-off-by: Yadunund <yadunund@openrobotics.org>
ooh I see. Thanks for hunting down the cause. Let me know if the new comment is better. |
Thanks, looks good. There is also a linter warning: /~https://github.com/ros2/ros_buildfarm_config/pull/285/files#diff-9f0c82d1eeac7ed26941b0d693125cb96ccdc63d7f5e220a4445fd7ccc3be1e9 |
I believe there are a few reasons. There's also no OMPL which kills the Smac Planner. I believe there's a couple of others |
Having
I'm working on getting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's typically only necessary to block the most upstream packages in this list, as downstream packages would be disabled implicitly, but navigation2
has a lot of packages and it might be hard to tease apart.
I'm also hoping to get these unblocked in the not-too-distant future, so hopefully this will be short-lived.
Wow that's great to hear, Scott! |
This PR blacklists
nav2_bringup
on arm64: https://build.ros2.org/view/Ibin_ujv8_uJv8/job/Ibin_ujv8_uJv8__nav2_bringup__ubuntu_jammy_arm64__binary/for Rolling and Iron.
cc: @SteveMacenski