Add note on multirobot refactor to migration guide #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
7 tasks
SteveMacenski
requested changes
Nov 20, 2024
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
|
One more thing and this should be done https://docs.nav2.org/tuning/index.html --> remove the |
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
luca-della-vedova
force-pushed
the
luca/multirobot_migration
branch
from
315efce to
662efa0
Compare
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
SteveMacenski
approved these changes
Nov 25, 2024
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
|
I fixed some formatting for you, LGTM |
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
|
It shows that I only wrote markdown in my life 😅, noticed that the highlighting of snippets wasn't working because it's supposed to be double backtick so fixed that in 3cc1e2e |
SteveMacenski
requested changes
Nov 27, 2024
|
Otherwise, I can merge |
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
SteveMacenski
approved these changes
Dec 3, 2024
alexanderjyuen
pushed a commit
to alexanderjyuen/docs.nav2.org
that referenced
this pull request
Dec 11, 2024
* Add note on multirobot refactor to migration guide Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Add example for configuration of sensor topic Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Add notes to topic configuration guides Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Fix formatting Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Remove use_namespace parameter Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Remove map_topic parameter and add migration note Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Update Jazzy.rst Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Add migration note on Costmap2DROS constructors Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Change all literals to double backtick Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Grammar Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Update default value / remove reference to global param Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> --------- Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
alexanderjyuen
pushed a commit
to alexanderjyuen/docs.nav2.org
that referenced
this pull request
Dec 11, 2024
* Add note on multirobot refactor to migration guide Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Add example for configuration of sensor topic Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Add notes to topic configuration guides Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Fix formatting Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Remove use_namespace parameter Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Remove map_topic parameter and add migration note Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Update Jazzy.rst Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Add migration note on Costmap2DROS constructors Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Change all literals to double backtick Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Grammar Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Update default value / remove reference to global param Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> --------- Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
alexanderjyuen
pushed a commit
to alexanderjyuen/docs.nav2.org
that referenced
this pull request
Dec 11, 2024
* Add note on multirobot refactor to migration guide Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Add example for configuration of sensor topic Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Add notes to topic configuration guides Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Fix formatting Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Remove use_namespace parameter Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Remove map_topic parameter and add migration note Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Update Jazzy.rst Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Add migration note on Costmap2DROS constructors Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Change all literals to double backtick Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Grammar Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Update default value / remove reference to global param Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> --------- Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add migration for PR ros-navigation/navigation2#4715