wip - add a trigger helper

rom-rb · Jun 16, 2021 · 2cc38aa · 2cc38aa
1 parent 025172f
commit 2cc38aa
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 13 deletions.
diff --git a/lib/rom/components/command.rb b/lib/rom/components/command.rb
@@ -18,10 +18,8 @@ class Command < Core
 
       # @api public
       def build(relation:)
-        gateway = gateways[relation.gateway]
-
-        notifications.trigger(
-          "configuration.commands.class.before_build",
+        trigger(
+          "commands.class.before_build",
           command: constant,
           gateway: gateways[relation.gateway],
           dataset: relation.dataset,

diff --git a/lib/rom/components/core.rb b/lib/rom/components/core.rb
@@ -33,6 +33,11 @@ def build(**)
         raise NotImplementedError
       end
 
+      # @api public
+      def trigger(event, payload)
+        notifications.trigger("configuration.#{event}", payload)
+      end
+
       # @api public
       def notifications
         configuration.notifications

diff --git a/lib/rom/components/relation.rb b/lib/rom/components/relation.rb
@@ -36,20 +36,15 @@ def build(registry:, command_compiler:)
         # TODO: this should become a built-in feature, no neeed to use a plugin
         constant.use(:registry_reader, relations: relation_names)
 
-        notifications.trigger(
-          "configuration.relations.class.ready", relation: constant, adapter: adapter
-        )
+        trigger("relations.class.ready", relation: constant, adapter: adapter)
 
         schema = finalize_schema(registry)
 
         apply_plugins
 
         dataset = gateway.dataset(schema.name.dataset).instance_exec(constant, &constant.dataset)
 
-        notifications.trigger(
-          "configuration.relations.dataset.allocated",
-          dataset: dataset, relation: constant, adapter: adapter
-        )
+        trigger("relations.dataset.allocated", dataset: dataset, relation: constant, adapter: adapter)
 
         # TODO: this will be removed once mapper registry is lazy-by-default
         mappers = finalize_mappers

diff --git a/lib/rom/components/schema.rb b/lib/rom/components/schema.rb
@@ -35,12 +35,12 @@ def build(registry:)
           registry: registry
         }
 
-        notifications.trigger("configuration.relations.schema.allocated", payload)
+        trigger("relations.schema.allocated", payload)
 
         # TODO: it would be great if we could remove setting schemas as a class ivar
         relation.set_schema!(schema)
 
-        notifications.trigger("configuration.relations.schema.set", payload)
+        trigger("relations.schema.set", payload)
 
         schema
       end