Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: make pimport a setuptools script #138

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Mar 22, 2021

The pimport script seems redundant if using the setuptools-based console scripts: https://setuptools.readthedocs.io/en/latest/userguide/entry_point.html#console-scripts

This PR changes pass-import to use that convention.

I'm open to suggestions as to what I'm missing about pimport's usage, but it seems to me that the entry_points command is better-supported than scripts, and it saves having a redundant file.

In a specific use-case, on NixOS/nixpkgs, the scripts option is actually NOT desired, because the pimport script is simply copied and then needs to be manually wrapped to recognize the python environment, instead of using the built-in infrastructure for handling entry_points. See NixOS/nixpkgs#117165.

@roddhjav roddhjav merged commit ccdb699 into roddhjav:master Mar 22, 2021
@roddhjav
Copy link
Owner

Thanks, merged.

@drewrisinger drewrisinger deleted the dr-pr-pimport-console-script branch March 22, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants