document selection line width DPI scaling #401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
has been deprecated for a while now. Closes: resurrecting-open-source-projects#207 Closes: resurrecting-open-source-projects#236
been deprecated for a while now. Ref: resurrecting-open-source-projects#231
It seems that the lowest confirmed imlib2 version `scrot` can build with is `v1.4.7` which was released in 2015-04-04. (Imlib2 `v1.4.6` wouldn't build for me, though I didn't really troubleshoot the build error at all). Going by the [git history](https://gitlab.freedesktop.org/xorg/lib/libxcomposite/-/blob/7098e81fd4d933ca922431280579049396466d23/src/Xcomposite.c) of XComposite, `v0.2.0` from 2005 seem to have the functions that we use. So let's just go with that. (I didn't do any runtime testing, though). Whether XFixes uses semantic versioning is not clear. But in any case, there was a CVE fix in 5.0.1 related to XFixesGetCursorImage() (which is the only function from XFixes scrot uses). And it doesn't seem like version 6.0.0 broke anything regarding XFixesGetCursorImage() so go ahead and settle on `v5.0.1` for XFixes. Xinerama v1.1.3 was released 10 years ago and seems to contain a CVE fix. So let's go for that. Closes: resurrecting-open-source-projects#307
the imlib2 version on it is way too old.
allows better default on high dpi displays where the previous default of 1 pixel would've been too small. Closes: resurrecting-open-source-projects#285
N-R-K
requested changes
Feb 10, 2025
| @@ -175,7 +175,9 @@ SELECTION STYLE | |||
|
|
|||
| Without the -l option, a default style is used: | |||
|
|
|||
| mode=auto,style=solid,width=...,opacity=100 # FIXME: width | |||
| mode=auto,style=solid,width=...,opacity=100 | |||
There was a problem hiding this comment.
Maybe remove width=... entirely.
|
Updated in 2530de5. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.