Drop ReplicationStrategy
#2514
Open
Drop ReplicationStrategy
#2514
+372
−548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Extend the Partition to inlcude more partition related attributes. This now include: - Log Id - Database Name - Column Family Name So far these values are defaults and there is no way to change them but this will probably change in the future This PR only adds those fields to the partition structure but the rest of the system still not using it. This should happen in a follow up PR.
This was referenced Jan 20, 2025
Summary: The idea here is that we can't use `ReplicationStategy` because it's not location aware and instead we should describe placement in terms of `ReplicationProperty`. If placement stragety is not set the system assume placement is done on all nodes, otherwise the num of copies described by the replication property is used. > Right now the placement is still not location aware but this will most probably change in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop
ReplicationStrategySummary:
The idea here is that we can't use
ReplicationStategybecause it's not location aware and instead we should describe
placement in terms of
ReplicationProperty.If placement stragety is not set the system assume placement is done
on all nodes, otherwise the num of copies described by the replication
property is used.
Stack created with Sapling. Best reviewed with ReviewStack.
ReplicationStrategy#2514NodeSetSelectionStrategy#2513