[RocksDb] Tables consolidation #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedSoliman
force-pushed
the
pr1466
branch
2 times, most recently
from
d13598f to
c61491b
Compare
tillrohrmann
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Thanks for creating this PR @AhmedSoliman. The changes look good to me. I left a few minor comments. +1 for merging.
Comment on lines
+74
to
+79
| // Ensures that both types have the same length, this makes it possible to | ||
| // share prefix extractor in rocksdb. | ||
| const_assert_eq!( | ||
| std::mem::size_of::<PartitionKey>(), | ||
| std::mem::size_of::<PartitionId>(), | ||
| ); |
| Idempotency => IDEMPOTENCY_TABLE_NAME, | ||
| } | ||
| const fn cf_name(_kind: TableKind) -> &'static str { | ||
| PARTITION_CF | ||
| } | ||
|
|
||
| #[derive(Debug, Copy, Clone, Eq, PartialEq)] | ||
| pub enum TableKind { |
There was a problem hiding this comment.
What is the plan for the TableKind abstraction? It seems that it does not add a lot of value right now. Maybe it could be removed?
There was a problem hiding this comment.
Or is this one of the follow-ups?
There was a problem hiding this comment.
I think it's still a useful abstraction, it's now possible to have multiple keys per table, but we might revisit this at some point and clean it up. I'd say that I wouldn't remove it prematurely and only do that when it becomes a hindrance.
This was referenced Apr 26, 2024
This is one step in a series of changes to move to a one CF per partition-id. The change consolidates all partitions into a single CF `data-unpartitioned`. Notes: - This introduces a fixed key prefix to partition CF to improve bloom filter lookups. This change require some subtle handling of scans that spans multiple prefixes, this is handled and is covered by existing test cases. - This adds the ability for a table to have multiple KeyKinds attached. Each TableKey has an associated kind, and the table (TableKind) has a set of KeyKinds associated. - This is designed to allow future separation of tables, or even individual key kinds to separate CFs. - Some values are intentionally passed but not used for (a) clarity at call site and (b) to help with follow-up refactoring. Side note: cluster marker tests fail sporadically, this adds a flush after each temp file write in an attempt to fix them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[RocksDb] Tables consolidation
This is one step in a series of changes to move to a one CF per partition-id. The change consolidates all partitions into a single CF
data-unpartitioned.Notes:
Side note: cluster marker tests fail sporadically, this adds a flush after each temp file write in an attempt to fix them.
Stack created with Sapling. Best reviewed with ReviewStack.