feat: Switch to Timestamp type
#33648
Merged
+573
−401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Jan 17, 2025
…ultiple schemas - Removed nullable handling for TimestampSchema in various datasource schemas, ensuring consistent timestamp validation. - Updated related tests to reflect the changes in schema definitions. This change enhances the reliability of timestamp parsing throughout the application.
…asource schemas - Updated various datasource schemas to use MaybeTimestamp instead of TimestampSchema, allowing for nullable timestamp handling. - Adjusted related tests to ensure compatibility with the new schema definitions. This change improves flexibility in timestamp validation across the application.
viceice
reviewed
Jan 20, 2025
viceice
approved these changes
Jan 22, 2025
|
🎉 This PR is included in version 39.123.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: