Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): allow multiple branch/pr limits #32556

Merged

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Nov 15, 2024

Changes

Allows concurrent and hourly limits to be set in package rules. (implemented everything mentioned in this comment)

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or (required will add after review of code)
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository (Tested both old and new behaviour)

Old Behaviour: follows hourly limits, 1, 2, 3
New Behaviour 1, 2, 3

Note: Test descriptions present in readme of each test repo

@RahulGautamSingh RahulGautamSingh marked this pull request as draft November 15, 2024 03:20
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review November 15, 2024 04:38
@RahulGautamSingh RahulGautamSingh marked this pull request as draft November 15, 2024 04:52
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review November 15, 2024 05:03
lib/workers/repository/update/branch/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/process/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.spec.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/repository/process/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/branch/index.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a big refactor is included in this PR and it would be easier to review if it would be split out.
Before we calculated and logged the remaining values, now we calculate the current count only

lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/repository/process/limits.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/process/limits.ts Show resolved Hide resolved
@rarkins
Copy link
Collaborator

rarkins commented Dec 13, 2024

It seems a big refactor is included in this PR and it would be easier to review if it would be split out.
Before we calculated and logged the remaining values, now we calculate the current count only

You seem to be describing the intended feature / behavior change of this PR. It's not a refactor..

@rarkins
Copy link
Collaborator

rarkins commented Dec 20, 2024

Merge after holidays

@rarkins rarkins marked this pull request as draft December 20, 2024 13:20
@rarkins rarkins marked this pull request as ready for review December 20, 2024 13:21
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge after holidays

@MPV
Copy link
Contributor

MPV commented Jan 20, 2025

Happy new year! 🎊
Fingers crossed for being able to try this out soon. ❤️ 🙏

@rarkins rarkins added this pull request to the merge queue Jan 21, 2025
Merged via the queue into renovatebot:main with commit 03f2229 Jan 21, 2025
71 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.119.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@allanlewis
Copy link

Thanks so much for getting this merged, it will be a game-changer for my monorepo!

How can I find out when v39.119.0 makes its way into the hosted version of Renovate?

RahulGautamSingh added a commit to RahulGautamSingh/renovate that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate pr/branch limits per-branch Allow multiple branch/PR limit groups
7 participants