User attribute is ignored in Conan packages

[dazze1812]

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us what version of Renovate you run.

37.61.4

If you're self-hosting Renovate, select which platform you are using.

GitLab self-hosted

Was this something which used to work for you, and then stopped?

I have not seen this working

Describe the problem

Our internal Conan packages have the user attribute set. E.g.
test_requires = "googletest/1.11.0@company"

When renovate looks for package versions in the registry, the user attribute is ignored:

2023-11-29T13:44:35.352931673Z                  "depName": "googletest",
2023-11-29T13:44:35.352938155Z                  "packageName": "googletest/1.11.0@_/_",
                 "currentValue": "1.11.0",
2023-11-29T13:44:35.352952682Z                  "replaceString": "googletest/1.11.0",
2023-11-29T13:44:35.352958964Z                  "depType": "requires",
2023-11-29T13:44:35.352964454Z                  "updates": [],
2023-11-29T13:44:35.352970886Z                  "versioning": "conan",
2023-11-29T13:44:35.352977479Z                  "warnings": [
2023-11-29T13:44:35.352990844Z                    {
2023-11-29T13:44:35.353000382Z                      "topic": "googletest/1.11.0@_/_",
2023-11-29T13:44:35.353006843Z                      "message": "Failed to look up conan package googletest/1.11.0@_/_"

Relevant debug logs

Logs

Copy/paste the relevant log(s) here, between the starting and ending backticks

Have you created a minimal reproduction repository?

Placeholder value, please select the correct response from the dropdown

[rarkins]

Hi @segretil, you modified similar code in #16871. Do you have any advice here?

[ErikTempelaarVO]

I believe user/channel is optional for conan, I have several dependencies with a fixed recipe revision in my conanfile.py.
(All without @/). Seems that this format is not understood correctly.

This works fine for Conan, but Renovate doesn't notify me of updates:

self.requires("spdlog/1.10.0#41d5d11adebeadd99647ffe02bd22fe0")

It does work for entries without an explicit revision (created as test), excerpt from a PR:

-        self.requires("nlohmann_json/3.9.1")
+        self.requires("nlohmann_json/3.11.3")

The debug-log shows the following line for spdlog:

2023-12-19T03:03:23.8283548Z DEBUG: Dependency spdlog/1.10.0#41d5d11adebeadd99647ffe02bd22fe0@_/_ has unsupported/unversioned value 1.10.0#41d5d11adebeadd99647ffe02bd22fe0 (versioning=conan)

This results in skipReason: invalid-value

2023-12-19T03:04:05.4414894Z        "config": {
2023-12-19T03:04:05.4415099Z          "conan": [
2023-12-19T03:04:05.4415866Z            {
2023-12-19T03:04:05.4416173Z              "deps": [
2023-12-19T03:04:05.4416389Z                {
2023-12-19T03:04:05.4416592Z                  "depName": "xerces-c",
2023-12-19T03:04:05.4417218Z                  "packageName": "xerces-c/3.2.2#cb2f599ac61701a1a73b82681f7ceab0@_/_",
2023-12-19T03:04:05.4418249Z                  "currentValue": "3.2.2#cb2f599ac61701a1a73b82681f7ceab0",
2023-12-19T03:04:05.4419611Z                  "replaceString": "xerces-c/3.2.2#cb2f599ac61701a1a73b82681f7ceab0",
2023-12-19T03:04:05.4419961Z                  "depType": "requires",
2023-12-19T03:04:05.4420166Z                  "updates": [],
2023-12-19T03:04:05.4421242Z                  "versioning": "conan",
2023-12-19T03:04:05.4421501Z                  "warnings": [],
2023-12-19T03:04:05.4422410Z                  "skipReason": "invalid-value",
2023-12-19T03:04:05.4424809Z                  "fixedVersion": "3.2.2#cb2f599ac61701a1a73b82681f7ceab0"
2023-12-19T03:04:05.4425667Z                },
2023-12-19T03:04:05.4425932Z                {
2023-12-19T03:04:05.4426682Z                  "depName": "spdlog",
2023-12-19T03:04:05.4427044Z                  "packageName": "spdlog/1.10.0#41d5d11adebeadd99647ffe02bd22fe0@_/_",
2023-12-19T03:04:05.4427340Z                  "currentValue": "1.10.0#41d5d11adebeadd99647ffe02bd22fe0",
2023-12-19T03:04:05.4427623Z                  "replaceString": "spdlog/1.10.0#41d5d11adebeadd99647ffe02bd22fe0",
2023-12-19T03:04:05.4428040Z                  "depType": "requires",
2023-12-19T03:04:05.4428235Z                  "updates": [],
2023-12-19T03:04:05.4428428Z                  "versioning": "conan",
2023-12-19T03:04:05.4428639Z                  "warnings": [],
2023-12-19T03:04:05.4429146Z                  "skipReason": "invalid-value",
2023-12-19T03:04:05.4429481Z                  "fixedVersion": "1.10.0#41d5d11adebeadd99647ffe02bd22fe0"
2023-12-19T03:04:05.4429707Z                },
2023-12-19T03:04:05.4429901Z                {
2023-12-19T03:04:05.4430095Z                  "depName": "open62541",
2023-12-19T03:04:05.4430981Z                  "packageName": "open62541/1.3.4#5985346a15abb4a0ddcc6af7de20509b@_/_",
2023-12-19T03:04:05.4431246Z                  "currentValue": "1.3.4#5985346a15abb4a0ddcc6af7de20509b",
2023-12-19T03:04:05.4431531Z                  "replaceString": "open62541/1.3.4#5985346a15abb4a0ddcc6af7de20509b",
2023-12-19T03:04:05.4431762Z                  "depType": "requires",
2023-12-19T03:04:05.4431968Z                  "updates": [],
2023-12-19T03:04:05.4432337Z                  "versioning": "conan",
2023-12-19T03:04:05.4432716Z                  "warnings": [],
2023-12-19T03:04:05.4433047Z                  "skipReason": "invalid-value",
2023-12-19T03:04:05.4433312Z                  "fixedVersion": "1.3.4#5985346a15abb4a0ddcc6af7de20509b"
2023-12-19T03:04:05.4433561Z                },
2023-12-19T03:04:05.4433745Z                {
2023-12-19T03:04:05.4433962Z                  "depName": "openssl",
2023-12-19T03:04:05.4434210Z                  "packageName": "openssl/3.1.3#35e30a39a89ee3ae98929377ebe78913@_/_",
2023-12-19T03:04:05.4435149Z                  "currentValue": "3.1.3#35e30a39a89ee3ae98929377ebe78913",
2023-12-19T03:04:05.4435442Z                  "replaceString": "openssl/3.1.3#35e30a39a89ee3ae98929377ebe78913",
2023-12-19T03:04:05.4436899Z                  "depType": "requires",
2023-12-19T03:04:05.4438745Z                  "updates": [],
2023-12-19T03:04:05.4440530Z                  "versioning": "conan",
2023-12-19T03:04:05.4440655Z                  "warnings": [],
2023-12-19T03:04:05.4440918Z                  "skipReason": "invalid-value",
2023-12-19T03:04:05.4441075Z                  "fixedVersion": "3.1.3#35e30a39a89ee3ae98929377ebe78913"
2023-12-19T03:04:05.4441222Z                },
2023-12-19T03:04:05.4441315Z                {
2023-12-19T03:04:05.4441425Z                  "depName": "nlohmann_json",
2023-12-19T03:04:05.4441584Z                  "packageName": "nlohmann_json/3.9.1@_/_",
2023-12-19T03:04:05.4441718Z                  "currentValue": "3.9.1",
2023-12-19T03:04:05.4441877Z                  "replaceString": "nlohmann_json/3.9.1",
2023-12-19T03:04:05.4442010Z                  "depType": "requires",
2023-12-19T03:04:05.4442122Z                  "updates": [
2023-12-19T03:04:05.4442237Z                    {
2023-12-19T03:04:05.4442421Z                      "bucket": "non-major",
2023-12-19T03:04:05.4442563Z                      "newVersion": "3.11.3",
2023-12-19T03:04:05.4442686Z                      "newValue": "3.11.3",
2023-12-19T03:04:05.4442799Z                      "newMajor": 3,
2023-12-19T03:04:05.4442927Z                      "newMinor": 11,
2023-12-19T03:04:05.4443042Z                      "updateType": "minor",
2023-12-19T03:04:05.4443175Z                      "isBump": true,
2023-12-19T03:04:05.4443353Z                      "branchName": "renovate/nlohmann_json-3.x"
2023-12-19T03:04:05.4443475Z                    }
2023-12-19T03:04:05.4443586Z                  ],

[ErikTempelaarVO]

I'm new to this, but I forked the repo used for the revision-feature and added some new dependencies to it:
/~https://github.com/ErikTempelaarVO/renovate-conan-revisions

Here's the log:
https://developer.mend.io/github/ErikTempelaarVO/renovate-conan-revisions/-/job/2ba87ceb-9d0b-4706-988d-8bd2934df98a

[ErikTempelaarVO]

This is wrong:

spdlog/1.10.0#41d5d11adebeadd99647ffe02bd22fe0@_/_

It should be something like this:

spdlog/1.10.0@_/_#41d5d11adebeadd99647ffe02bd22fe0

[segretil]

I think this is a different issue than the one @dazze1812 mentionned, however it should also be fixed !

[ErikTempelaarVO]

Great work, thanks!

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the discussion if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

[dazze1812]

To reproduce this problem a private Conan repository server is required. I can't provide that at the moment.

[segretil]

Sorry for the late reply, I think as a workaround you can add the channel like this test_requires = "googletest/1.11.0@company/_" and it should work.

To fix the issue, I can take a quick a look.

[segretil]

Interesting ! However I don't think we will be able to use it because it forces the use of channels to identify the package on Github and we need to omit the channel attribute to reproduce @dazze1812's case.

[dazze1812]

When I use test_requires = "googletest/1.11.0@company/_" it works.

[dazze1812]

Maybe the problem is in

const regex = regEx(
  `(?<name>[-_a-z0-9]+)/(?<version>[^@\n{*"']+)(?<userChannel>@[-_a-zA-Z0-9]+/[^#\n.{*"' ]+)?#?(?<revision>[-_a-f0-9]+[^\n{*"'])?`,
);

The channel seems to be mandatory?

Maybe (?<name>[-_a-z0-9]+)/(?<version>[^@\n{*"']+)(?<userChannel>@[-_a-zA-Z0-9]+(/[^#\n.{*"' ]+|))?#?(?<revision>[-_a-f0-9]+[^\n{*"'])? is better?

[dazze1812]

Created a pull request -> #26516