Vite: replace <LiveReload/> with <DevScripts/>
#8609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcattori
force-pushed
the
pedro/devscripts
branch
from
f2a9998 to
80feb71
Compare
🦋 Changeset detectedLatest commit: d0d8428 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Closed
houmark
reviewed
Jan 27, 2024
pcattori
force-pushed
the
pedro/devscripts
branch
2 times, most recently
from
4db4fc6 to
ca95b24
Compare
brophdawg11
reviewed
Jan 29, 2024
pcattori
force-pushed
the
pedro/devscripts
branch
from
ca95b24 to
d0d8428
Compare
|
Alternative would be to have something like: import {
- LiveReload,
Scripts,
Outlet,
}
export default function App() {
return (
<html>
<body>
- <LiveReload />
<Scripts />
<Outlet />
</body>
</html>
)
}Where |
|
Superceded by #8636 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change for projects using the unstable Vite plugin.
The
<LiveReload/>component has a confusing name as it now also supports HMR and HDR.Additionally, it provides an bespoke client-side runtime that is obsoleted by Vite.
To get our Vite plugin working, we were doing some compiler magic to swap out the
implementation of
<LiveReload/>.This was always meant as a temporary measure.
Now we have a better solution in the form of a new
<DevScripts/>component specificallydesigned with Vite's HMR capabilities in mind.
The
<LiveReload />component will cease to provide HMR and HDR capabilities in Vite,so you'll need to replace
<LiveReload/>with<DevScripts/>in your app.The
<DevScripts/>component should be placed in the<head/>of your app so that itcan be loaded before any other scripts as required by React Fast Refresh.
import { - LiveReload, + DevScripts, Outlet, } export default function App() { return ( <html> <head> + <DevScripts /> </head> <body> - <LiveReload /> <Outlet /> </body> </html> ) }Tried to directly inject the HMR runtime into the
<head/>instead (#8604) but that still had issues with race conditions.