Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consistent component tree for useId #9805

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Ensure consistent component tree for useId #9805

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cb0fd9
Ensure consistent component tree for useId
brophdawg11 Jan 3, 2023
190c776
Fix typo
brophdawg11 Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix typo 
Co-authored-by: Jacob Ebey <jacob.ebey@live.com>
  • Loading branch information
@brophdawg11 @jacob-ebey
brophdawg11 and jacob-ebey authored Jan 4, 2023
commit 190c77682fd6b97886453c355f27d0c1cb757c85
2 changes: 1 addition & 1 deletion packages/react-router/lib/components.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export function RouterProvider({
// useId happy when we are server-rendering since we may have a <script> here
// containing the hydrated server-side staticContext (from StaticRouterProvider).
// useId relies on the component tree structure to generate deterministic id's
// so we need to ensure it remains remains the same on the client even though
// so we need to ensure it remains the same on the client even though
// we don't need the <script> tag
return (
<>
Expand Down