Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-rotuer): Fixed bug when using useSearchParams with useBlocker #12784

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

yuhwan-park
Copy link

Issue Overview

  1. When passing the original searchParams to nextInit, if the nextInit implementation modifies properties using methods like delete() or add(). the internal property values of searchParams change before the navigate function executes.
  2. When used together with the useBlocker hook, this can lead to searchParams values that don't match with location.search (which is a dependency).

Solution

  • Modified to create a new URLSearchParams instance that points to a different memory address than searchParams. This ensures that even if searchParams values are modified in the nextInit function, the searchParams within the hook remains unchanged.

I have confirmed that issue #12256 has been resolved by implementing the exact solution specified in the issue description.

closes: #12256 #12188

Copy link

changeset-bot bot commented Jan 20, 2025

⚠️ No Changeset found

Latest commit: 518c2df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 20, 2025

Hi @yuhwan-park,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 20, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@yuhwan-park yuhwan-park changed the title Fixed bug when using useSearchParams with useBlocker fix(react-rotuer): Fixed bug when using useSearchParams with useBlocker Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant