Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reveal and routes CLI commands #12745

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Jan 15, 2025

These commands seem to have been broken since they didn't preload the ESM build like our dev and build commands do. Since we've recently introduced our own config decoupled from Vite, I've updated these commands to use our config loader directly.

This got missed because the reveal test was being skipped since migrating to Vite had broken it. I've re-enabled the test and fixed it. I've also added a basic smoke test for the routes command that would have failed before this fix.

Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: 11ee2a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish merged commit c364bd4 into dev Jan 16, 2025
8 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/fix-reveal-routes-commands branch January 16, 2025 00:14
Copy link
Contributor

🤖 Hello there,

We just published version 7.1.3-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 7.1.3 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants