Remove console log

remix-run · Jan 16, 2025 · d08cbb6 · d08cbb6
1 parent 9b7465a
commit d08cbb6
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 27 deletions.
diff --git a/integration/single-fetch-test.ts b/integration/single-fetch-test.ts
@@ -1703,34 +1703,31 @@ test.describe("single-fetch", () => {
   test("does not try to encode a turbo-stream body into 204 responses", async ({
     page,
   }) => {
-    let fixture = await createFixture(
-      {
-        files: {
-          ...files,
-          "app/routes/_index.tsx": js`
-            import { data, Form, useActionData, useNavigation } from "react-router";
+    let fixture = await createFixture({
+      files: {
+        ...files,
+        "app/routes/_index.tsx": js`
+          import { data, Form, useActionData, useNavigation } from "react-router";
 
-            export async function action({ request }) {
-              await new Promise(r => setTimeout(r, 500));
-              return data(null, { status: 204 });
-            };
+          export async function action({ request }) {
+            await new Promise(r => setTimeout(r, 500));
+            return data(null, { status: 204 });
+          };
 
-            export default function Index() {
-              const navigation = useNavigation();
-              const actionData = useActionData();
-              return (
-                <Form method="post">
-                  {navigation.state === "idle" ? <p data-idle>idle</p> : <p data-active>active</p>}
-                  <button data-submit type="submit">{actionData ?? 'no content!'}</button>
-                </Form>
-              );
-            }
-          `,
-        },
+          export default function Index() {
+            const navigation = useNavigation();
+            const actionData = useActionData();
+            return (
+              <Form method="post">
+                {navigation.state === "idle" ? <p data-idle>idle</p> : <p data-active>active</p>}
+                <button data-submit type="submit">{actionData ?? 'no content!'}</button>
+              </Form>
+            );
+          }
+        `,
       },
-      ServerMode.Development
-    );
-    let appFixture = await createAppFixture(fixture, ServerMode.Development);
+    });
+    let appFixture = await createAppFixture(fixture);
 
     let app = new PlaywrightFixture(appFixture, page);
 

diff --git a/packages/react-router/lib/server-runtime/server.ts b/packages/react-router/lib/server-runtime/server.ts
@@ -306,9 +306,8 @@ async function handleSingleFetchRequest(
   //   https://datatracker.ietf.org/doc/html/rfc9110#name-204-no-content
   //   https://datatracker.ietf.org/doc/html/rfc9110#name-205-reset-content
   //   https://datatracker.ietf.org/doc/html/rfc9110#name-304-not-modified
-  const NO_BODY_STATUS_CODES = new Set([100, 101, 204, 205, 304]);
+  let NO_BODY_STATUS_CODES = new Set([100, 101, 204, 205, 304]);
   if (NO_BODY_STATUS_CODES.has(status)) {
-    console.log("returning single fetch response with no body");
     return new Response(null, { status, headers: resultHeaders });
   }